Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten K8upStatus spec #191

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Flatten K8upStatus spec #191

merged 1 commit into from
Dec 8, 2020

Conversation

ccremer
Copy link
Contributor

@ccremer ccremer commented Dec 8, 2020

It's probably history, but it only adds unnecessary complexity today

@ccremer ccremer requested a review from cimnine December 8, 2020 15:33
cimnine
cimnine approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No functionality change can be observed, this is purely a semantic change. Therefore I believe there are no implications on compatibility etc. I've added to minor remarks, which are rooted in my curiosity rather than a request for change.

job/job.go Outdated Show resolved Hide resolved
api/v1alpha1/status.go Show resolved Hide resolved
@ccremer
Refactor: Flatten K8upStatus spec
e6543fb 
It's probably history, but it only adds unnecessary complexity today
@ccremer ccremer merged commit 672581a into master Dec 8, 2020
@ccremer ccremer deleted the status-fix branch December 8, 2020 16:07
@ccremer ccremer added the change Generic change that is neither a fix or feature label Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
change Generic change that is neither a fix or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccremer @cimnine