Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable LEADER_ELECTION by default for make run run_kind #200

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Disable LEADER_ELECTION by default for make run run_kind #200

merged 1 commit into from
Dec 10, 2020

Conversation

cimnine
Copy link
Contributor

@cimnine cimnine commented Dec 10, 2020

Without further configuration, k8up expects a k8s cluster to have a leader election namespace.

Just executing make run oder make run_kind therefore leads to the following error message:

0000-00-00T00:00:00.000+0100	ERROR	setup	unable to start K8up operator	{"error": "unable to find leader election namespace: not running in-cluster, please specify LeaderElectionNamespace"}

This PR adjusts the Makefile in a way such that when invoking the mentioned make targets no leader election namespace is required.

@cimnine cimnine requested a review from ccremer December 10, 2020 10:14
ccremer
ccremer approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@ccremer ccremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to add "for local development" in your commit message. Otherwise it shows up in the changelog and could lead to confusion if it's for production as well

@cimnine cimnine force-pushed the DisableLeaderElectionByDefault branch from 942aeff to df7e2aa Compare December 10, 2020 10:21
@cimnine cimnine merged commit a7ac4ef into master Dec 10, 2020
@cimnine cimnine deleted the DisableLeaderElectionByDefault branch December 10, 2020 10:22
@ccremer ccremer added the change Generic change that is neither a fix or feature label Dec 30, 2020
@ccremer ccremer changed the title Disable LEADER_ELECTION by default for make run run_kind Disable LEADER_ELECTION by default for make run run_kind Dec 30, 2020
@ccremer ccremer mentioned this pull request Dec 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccremer ccremer ccremer approved these changes

Assignees
No one assigned
Labels
change Generic change that is neither a fix or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cimnine @ccremer