Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JobSucceeded Condition to Status fields #218

Merged
merged 2 commits into from
Dec 29, 2020
Merged

Add JobSucceeded Condition to Status fields #218

merged 2 commits into from
Dec 29, 2020

Conversation

cimnine
Copy link
Contributor

@cimnine cimnine commented Dec 21, 2020 •
edited
Loading

Based on #204

Implements and closes #212

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Update tests.
  • Link this PR to related issues.

@cimnine cimnine changed the base branch from master to ExtendStatusWithConditions December 21, 2020 15:10
@cimnine cimnine force-pushed the 212JobCompletedConditions branch 2 times, most recently from 82491d5 to 3840213 Compare December 21, 2020 15:21
@cimnine
Copy link
Contributor Author

cimnine commented Dec 21, 2020

I will leave this issue in draft state until #204 is merged.

@cimnine cimnine requested a review from ccremer December 21, 2020 15:25
Base automatically changed from ExtendStatusWithConditions to master December 22, 2020 13:00
@cimnine cimnine marked this pull request as ready for review December 22, 2020 13:07
ccremer
ccremer reviewed Dec 22, 2020
View reviewed changes
observer/observer_test.go Outdated Show resolved Hide resolved
@tobru tobru added this to the v1.0.0-rc2 milestone Dec 22, 2020
@cimnine cimnine force-pushed the 212JobCompletedConditions branch 2 times, most recently from 5a7004c to 10b2b33 Compare December 22, 2020 15:02
ccremer
ccremer reviewed Dec 22, 2020
View reviewed changes
observer/observer_test.go Outdated Show resolved Hide resolved
@ccremer ccremer changed the title Job Completed Condition Add JobSucceeded Condition Dec 29, 2020
@ccremer ccremer added the enhancement New feature or request label Dec 29, 2020
@ccremer ccremer changed the title Add JobSucceeded Condition Add JobSucceeded Condition to Status fields Dec 29, 2020
@ccremer ccremer merged commit a78faa6 into master Dec 29, 2020
@ccremer ccremer deleted the 212JobCompletedConditions branch December 29, 2020 17:43
@ccremer ccremer mentioned this pull request Jan 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccremer ccremer ccremer left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0.0-rc2
Development

Successfully merging this pull request may close these issues.

[Feature] Extend the K8up Custom Resource's Status Conditions with a JobSuccessful Condition
3 participants
@cimnine @ccremer @tobru