Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add security context for cleanup hook #966

Merged

Conversation

afrimberger
Copy link
Contributor

@afrimberger afrimberger commented May 9, 2024

Summary

The operator deployment already supports setting podSecurityContext and securityContext. This PR allows setting both for the cleanup Job.

Checklist

For Helm Chart changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:chart
  • PR contains the chart label, e.g. chart:k8up
  • Variables are documented in the values.yaml using the format required by Helm-Docs.
  • Chart Version bumped if immediate release after merging is planned
  • I have run make chart-docs
  • Link this PR to related code release or other issues.

@afrimberger afrimberger requested a review from a team as a code owner May 9, 2024 08:41
@afrimberger afrimberger requested review from TheBigLee and wejdross and removed request for a team May 9, 2024 08:41
@TheBigLee TheBigLee requested a review from Kidswiss May 17, 2024 08:29
@TheBigLee
Copy link
Contributor

Hi @afrimberger Could you fix the DCO (sign the commit) so that all tests pass?

@afrimberger afrimberger force-pushed the feature/security-context-cleanup-job branch from c5b5ab2 to 25ea52e Compare May 17, 2024 11:27
@afrimberger
Copy link
Contributor Author

Hi @TheBigLee,

DCO is "green", now. Thanks for the hint.

I just looked at the Check list and didn't notice the red DCO build. Would be worth adding an entry "Commits signed off" to the Check list :).

Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing.

Once you've fixed this and the e2e ran through we can merge.

charts/k8up/Chart.yaml Outdated Show resolved Hide resolved
@afrimberger afrimberger force-pushed the feature/security-context-cleanup-job branch 2 times, most recently from 5073025 to 1bf80f1 Compare May 17, 2024 13:27
@afrimberger afrimberger requested a review from Kidswiss May 23, 2024 07:18
@TheBigLee
Copy link
Contributor

@afrimberger Can you run make chart-docs once more to fix the ChartLint check?
once this is done, we'll merge this PR.

Cheers

@TheBigLee
Copy link
Contributor

I just looked at the Check list and didn't notice the red DCO build. Would be worth adding an entry "Commits signed off" to the Check list :).

Thanks for the idea. We've added it to the checklist in #974

Signed-off-by: André Frimberger <andre@intellisoft.de>
@afrimberger afrimberger force-pushed the feature/security-context-cleanup-job branch from 1bf80f1 to 8b39c30 Compare June 1, 2024 17:57
Signed-off-by: André Frimberger <andre@intellisoft.de>
Signed-off-by: André Frimberger <andre@intellisoft.de>
@afrimberger afrimberger force-pushed the feature/security-context-cleanup-job branch from ab49abd to 77180bf Compare June 5, 2024 06:42
@afrimberger
Copy link
Contributor Author

@TheBigLee : docs are updated and I added another small commit for fixing the labels for the Grafana Dashboard ConfigMap

Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for the contribution 🎉

@Kidswiss Kidswiss merged commit 365b38b into k8up-io:master Jun 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants