-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generator to really be incremental #83
Conversation
bca9320
to
89f0bc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better! Just left a few notes 🙂
As a follow up in another PR, you might want to also switch the generator to use a pooled indented text writer rather than syntax trees, which is orders of magnitude faster and more efficient in terms of memory use (I've shared some screenshots here). It is the recommended approach to generate code from source generators. I'd recommend reusing my implementation here, which also includes an interpolated string handler to improve performance even more when interpolating output text 🚀
Thanks a lot (and @Youssef1313) for taking some of your time to review this. |
Fixes #82