Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String Catalogs #49

Open
mickeyl opened this issue Mar 19, 2024 · 2 comments
Open

String Catalogs #49

mickeyl opened this issue Mar 19, 2024 · 2 comments

Comments

@mickeyl
Copy link
Collaborator

mickeyl commented Mar 19, 2024

It would be nice to have support for the new string catalogues. They are a good addition, but fail to add typesafe enums like we do.

Introduction

@mickeyl
Copy link
Collaborator Author

mickeyl commented Jun 24, 2024

Here's a format example:

{
  "sourceLanguage" : "en",
  "strings" : {
    "Choose date" : {
      "localizations" : {
        "de" : {
          "stringUnit" : {
            "state" : "translated",
            "value" : "Datum aussuchen"
          }
        }
      }
    },
    "Completed %lld%%" : {
      "localizations" : {
        "de" : {
          "stringUnit" : {
            "state" : "translated",
            "value" : "Komplettiert %lld"
          }
        }
      }
    },
    "Done!" : {
      "localizations" : {
        "de" : {
          "stringUnit" : {
            "state" : "needs_review",
            "value" : "Fertig!"
          }
        },
        "en" : {
          "stringUnit" : {
            "state" : "translated",
            "value" : "Ready!"
          }
        }
      }
    },
    "Pick another date" : {

    }
  },
  "version" : "1.0"
}

@mickeyl
Copy link
Collaborator Author

mickeyl commented Jun 25, 2024

So this works now in principle, but I'm not sure whether it really is worth it. The new String Catalogue feature doesn't seem to be really cutting it. For me, it doesn't auto remove unused strings, the file only gets bigger. Manually removing a key isn't working either, you have to resort to edit the underlying .xcstrings file.

What are your experiences with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant