Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioning #18

Closed
IzzySoft opened this issue Jul 16, 2023 · 4 comments
Closed

versioning #18

IzzySoft opened this issue Jul 16, 2023 · 4 comments
Assignees

Comments

@IzzySoft
Copy link

Can you please take care about versioning? Currently, the APK on each release tag identifies with versionName: "1.0" and versionCode: 1.

  • versionName is what shows up in the app. On bug reports you might wish to know what version it is about – this is what will be reported.
  • versionCode is what Android uses internally to tell versions apart, and to decide if an APK is an update to the installed version. Currently, no update notifications will show up as the code never changes.

You can adjust this here in your build.gradle. Please do so whenever you make a new release, which then will show up here in my repo – if you wish you can pick a badge to link there e.g. from your Readme 😃

Thanks in advance!

@kaangiray26 kaangiray26 self-assigned this Jul 20, 2023
@kaangiray26
Copy link
Owner

kaangiray26 commented Jul 20, 2023

Thanks for pointing this out, I totally forgot about that! I've now published a new version that has its version numbers updated.

Cheers!

@IzzySoft
Copy link
Author

I totally forgot about that!

💩 happens 🙈

I've now published a new version that has its version numbers updated.

Thanks a lot! Looks good – and should become available with the next sync in my repo then (updates happen daily around 5:30 pm UTC and sync is usually complete around 6 pm UTC). Badge offer still stands 😉

Speaking about "offer": Would you accept a PR with a starter package for Fastlane structures? That would give you control on how your app is presented.

@kaangiray26
Copy link
Owner

That sounds nice!

I've added a directory for the fastlane structure, is the current status suitable for use? Actually I've been trying to make a release in the fdroid all night. Once the release is merged I'll add both badges for Fdroid and IzzyOnDroid.

Thanks

@IzzySoft
Copy link
Author

I've added a directory for the fastlane structure, is the current status suitable for use?

Wow, that looks really good indeed! May I suggest moving the screenshots from /images/screenshots to /fastlane/metadata/android/en-US/images/phoneScreenshots to complement this? Meanwhile, I've told my updater to fetch what was established now, whenever a new release is being fetched. Once screenshots are there, I'll amend that to the settings.

Actually I've been trying to make a release in the fdroid all night. Once the release is merged I'll add both badges for Fdroid and IzzyOnDroid.

Wonderful! Usually, once an app reaches F-Droid.org it gets removed from my repo – unless the authors explicitly request to keep it there. If you can achieve reproducible builds, that could be done (otherwise it might cause some confusion due to the different signatures; only with reproducible builds, F-Droid would ship the APK signed by you).

Expect includion with F-Droid take at least a few days (if you're lucky, it can be achieved in about a week. But usually it takes a bit more (if issues arise, it can stretch quite a bit). So you might consider adding the badge for my repo now (so interested folks already get the idea), and F-Droid's when it's ready.

kaangiray26 added a commit that referenced this issue Jul 22, 2023
kaangiray26 added a commit that referenced this issue Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants