Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Fishing or Mining something that uses open keep the phrase #84

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

thmsndk
Copy link
Contributor

@thmsndk thmsndk commented Dec 14, 2023

When you fish up lglitch instead of saying you got the item by fishing, it would say you just "Received" it. this patch preserves the context for Fishing and Mining in the phrase.

image

@kaansoral
Copy link
Owner

I think it should just say "Fished an Amulet of Intelligence"

@thmsndk
Copy link
Contributor Author

thmsndk commented Feb 4, 2024

I opted for keeping the item you opened in the message, in case you could fish other things up that would auto open (I know we can't now) but let's say we add clams that can contain clam meat or pearls, or something like that :P

But I can remove the additional message info if you feel that is better.

@FreezePhoenix
Copy link
Contributor

For convenience, clams or other things probably wouldn't auto-exchange on fishing them, you'd talk to the fisherman

@thmsndk
Copy link
Contributor Author

thmsndk commented Feb 15, 2024

@kaansoral It should now say

"Fished an Amulet of Intelligence"

Feel free to merge it :)

@FreezePhoenix
Copy link
Contributor

+1, this also fixes a bug with PVP marked exchanges. Previously, if the item being exchanged was marked with PVP, and there was an auto-open drop table entry (like basicelixir in G.drops.seashell) then the resulting item from that opened drop table would not have the PVP flag.

@kaansoral kaansoral merged commit 8e42ce7 into kaansoral:main Feb 21, 2024
1 check passed
@thmsndk thmsndk deleted the patch-1 branch May 8, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants