Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Add GrafanaDashboard, Secret and ConfigMap to pipeline ClusterRole, fix others #741

Merged
merged 4 commits into from
Jun 1, 2020

Conversation

ianpartridge
Copy link
Contributor

cc: @kvijai82

@ianpartridge
Copy link
Contributor Author

@kvijai82 why do some of the resources in this ClusterRole specify the plural name (appsodyapplications, serviceBindingRequests) and some specify the singular name (serviceMonitor, database)? Does it matter?

@ianpartridge ianpartridge requested a review from kvijai82 May 29, 2020 10:05
@kvijai82
Copy link
Contributor

@ianpartridge that's the change I am trying to test out with Terrance today and will be creating a PR for. It does matter.

kvijai82
kvijai82 previously approved these changes May 29, 2020
@ianpartridge
Copy link
Contributor Author

ianpartridge commented May 29, 2020

If it matters, do they have to be singular or plural? I would guess plural, because that's what we had for the existing resources (appsodyapplications, openlibertyapplications). If I'm correct, I guess that means I should update this PR to say grafanadashboards?

@ianpartridge
Copy link
Contributor Author

I saw that the CR you sent @tnixa was plural, so I've updated this PR accordingly. Hope that's correct.

@ianpartridge ianpartridge requested a review from kvijai82 May 29, 2020 15:06
@ianpartridge ianpartridge changed the title Add GrafanaDashboard to deploy pipeline ClusterRole Add GrafanaDashboard, Secret and ConfigMap to pipeline ClusterRole, fix others May 29, 2020
@ianpartridge
Copy link
Contributor Author

Also added Secret and ConfigMap as two core resources we expect users will want to include in their GitOps repo. Secret is definitely required in order to get OpenLiberty metrics working (because the /metrics endpoint requires authentication).

@kaczyns kaczyns merged commit 6824b21 into master Jun 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants