Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new release to plugin.xml #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add new release to plugin.xml #11

wants to merge 1 commit into from

Conversation

kabaros
Copy link
Owner

@kabaros kabaros commented Apr 18, 2020

No description provided.

@NateWr
Copy link

NateWr commented Apr 20, 2020

👍 Just trying to understand better: what's the difference between the /pr and /push checks?

@kabaros
Copy link
Owner Author

kabaros commented Apr 20, 2020

It's Travis default behaviour. When building PRs, it runs the build against the PR (/pr), but also tries to rebase master and run the build against the rebased branch (/push). It's apparently always been the case, but just started being exposed on Github api.

The solution would be to disable build on branches, and allow it only on PRs - travis-ci/travis-ci#1147 (comment) .. but not sure if that's what we want always. Since the two builds run in parallel, and don't seem to add to time, I left the default behaviour.

@NateWr
Copy link

NateWr commented Apr 20, 2020

Sounds good! Fine to leave it as-is just wanted to make sure I wasn't missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants