Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.0 -- New design #147

Merged
merged 154 commits into from
Nov 24, 2023
Merged

Release 1.2.0 -- New design #147

merged 154 commits into from
Nov 24, 2023

Conversation

marcianosr
Copy link
Contributor

What

Explain what changes inside the code, this can be as simple or complicated as you want as long as it's clear

Why

Explain why these things are changes. This explanation is for your colleagues and your future self.

Code Review

Please consider the following checklist when reviewing this Pull Request.
More background and details here.

  • Does the code actually solve the problem it was meant to solve?
  • Is the code covered by unit tests? Integration tests?
  • Does anything here need documentation? (Focus on why, not what.)
  • Does any of this code deal with privacy sensitive information or affects security? Ask an additional reviewer.
  • Is the code easy to understand and change in the future?
  • Is the same code or concept duplicated? Find a balance between DRYness and readability.
  • Does the code reasonably adhere to the Kabisa coding standards?
  • Be kind.

RoyAppeldoorn and others added 30 commits July 27, 2023 13:33
Used https://www.apollographql.com/docs/react/migrating/apollo-client-3-migration/
to migrate apollo to V3.0. Only uses @apollo/client which makes it a lot cleaner!
Also updated the graphql package to the newest version.
Breaking change: the error response does not contain "GraphQL Error:"
or "Network error:" anymore.
marcianosr and others added 27 commits October 18, 2023 16:37
Prevent default form behaviour on submit
Fix PullToRefresh not working as intended causing issues in touch scroll
Fix kudos amount input losing focus
Fix management lists not updating on crud actions
Replace @sandercamp/ui-components with @kabisa/ui-components
Fix autoFocus issue when typing in message box
@marcianosr marcianosr merged commit 0aac49d into master Nov 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants