Create topic based on hash #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimamula
force-pushed
the
create-topic-based-on-hash
branch
from
d7a9f73 to
0bdac00
Compare
tinjyuu
approved these changes
Jun 21, 2018
|
UI は雑ですがこんなイメージ |
chooblarin
reviewed
Jun 21, 2018
| @@ -179,7 +187,7 @@ const predict = async () => { | |||
| const predicted = tf.tidy(() => { | |||
| const img = capture(webcamera); | |||
| const activation = mobilenet.predict(img); | |||
| const predictions = model.predict(activation) as tf.Tensor<tf.Rank>; | |||
There was a problem hiding this comment.
僕の環境だとこのキャストが無いとエラーになるんですが，今村さんの環境ではイケてます？
[ts]
Property 'as1D' does not exist on type 'Tensor<Rank> | Tensor<Rank>[]'.
Property 'as1D' does not exist on type 'Tensor<Rank>[]'.
any
There was a problem hiding this comment.
おっと。すみません自分の環境でも tsc ではエラーでした。。
tslint の設定見直します！
There was a problem hiding this comment.
palantir/tslint#2736 に上がっているバグで、 no-unused-variable を使っていると他の rule （今回は no-unnecessary-type-assertion）が壊れる場合があり、それにはまっていたようなので、 no-unused-variable を無効にし、代わりに tsconfig.json の noUnusedLocals と noUnusedParameters を使うようにしました。
また、 CI のチェックで tsc が通ることも確認するようにしました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL の hash に基づいて制御対象のロボット、車輪を決めるようにしました 25f496d
ついでに、 tslint の導入 33f707f と CI で travis を使う 0bdac00 のもやってみました