New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test+Fix `iters.flatten` python2 unicode support. #78

Open

Digenis wants to merge 2 commits into kachayev:master from Digenis:fix_flatten_unicode

Contributor

Digenis commented Oct 9, 2015

is_string_or_bytes checks for str instances which is correct only for python3
while in python2 the right type is basestring.

Fixes #73

Bug demo in the build after adding tests.

Digenis added 2 commits

October 9, 2015 17:51


          test iters.flatten with unicode object

6b6962c


          python2 compatible flatten for strings

d5bffc9

Digenis mentioned this pull request

Fix flatten unicode fnpy/fn.py#9

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet