Update nodejs 20 since replacing ts-node-test with tsx (#1029)

* `npm uninstall @types/node && npm install --save-dev @types/node@20.4.4` * Bump nodejs to 20.x * `pm uninstall @tsconfig/node18 && npm install --save-dev @tsconfig/node20` * Update tsconfig * Update renovate config too * Need to specify module type since nodejs 20? * Enable allowImportingTsExtensions to suppress tsc error
kachick · Jul 23, 2023 · f505dd4 · f505dd4
1 parent fae617f
commit f505dd4
Show file tree

Hide file tree

Showing 8 changed files with 27 additions and 25 deletions.
diff --git a/.node-version b/.node-version
@@ -1 +1 @@
-18.16.1
+20.4.0
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -84,7 +84,7 @@ Actual behavior checking requires <https://github.com/uhop/node-re2> that includ
 ```console
 $ npm install
 $ npx tsx
-Welcome to Node.js v18.16.1.
+Welcome to Node.js v20.4.0.
 Type ".help" for more information.
 ```
 

diff --git a/default.nix b/default.nix
@@ -2,7 +2,7 @@
 
 pkgs.mkShell {
   buildInputs = [
-    pkgs.nodejs-18_x
+    pkgs.nodejs_20
     pkgs.dprint
     pkgs.nil
     pkgs.nixpkgs-fmt

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,11 +1,12 @@
 {
+  "type": "module",
   "scripts": {
     "test": "glob -c \"node --loader tsx --no-warnings --test\" \"./test/**/*_test.ts\""
   },
   "devDependencies": {
-    "@tsconfig/node18": "^18.2.0",
+    "@tsconfig/node20": "^20.1.0",
     "@tsconfig/strictest": "^2.0.1",
-    "@types/node": "^18.17.0",
+    "@types/node": "^20.4.4",
     "@typescript-eslint/eslint-plugin": "^6.1.0",
     "@typescript-eslint/parser": "^6.1.0",
     "eslint": "^8.45.0",

diff --git a/renovate.json b/renovate.json
@@ -13,7 +13,7 @@
     },
     {
       "matchPackageNames": ["nodejs/node"],
-      "allowedVersions": "/^v?18\\./"
+      "allowedVersions": "/^v?20\\./"
     },
     {
       "extends": ["schedule:weekly"],

diff --git a/test/regex_test.ts b/test/regex_test.ts
@@ -8,7 +8,7 @@ import path from 'path';
 import RE2 from 're2';
 import JSON5 from 'json5';
 
-import { examples } from './examples';
+import { examples } from './examples.ts';
 
 // Copied from https://github.com/renovatebot/renovate/blob/0296e58e19844b6eb3583ee3197bcae42e25d9f7/lib/config/types.ts#L169-L185
 // Because they does not expose these types via npm, AFAIK

diff --git a/tsconfig.json b/tsconfig.json
@@ -1,7 +1,8 @@
 {
-  "extends": ["@tsconfig/strictest/tsconfig", "@tsconfig/node18/tsconfig"],
+  "extends": ["@tsconfig/strictest/tsconfig", "@tsconfig/node20/tsconfig"],
   "compilerOptions": {
-    "noEmit": true
+    "noEmit": true,
+    "allowImportingTsExtensions": true
   },
   "include": ["**/*.ts"]
 }