Better typing #189
Merged
Better typing #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachick
commented
Jun 1, 2022
| @@ -13,7 +13,7 @@ class MonotonicGenerator | |||
| undef_method :instance_variable_set | |||
|
|
|||
| def initialize | |||
| super() | |||
| super | |||
There was a problem hiding this comment.
I'm bit negative for this change. 🤔
There was a problem hiding this comment.
kachick
commented
Jun 1, 2022
Comment on lines
+14
to
+23
| - range: | ||
| start: | ||
| line: 233 | ||
| character: 23 | ||
| end: | ||
| line: 233 | ||
| character: 27 | ||
| severity: ERROR | ||
| message: Type `::Numeric` does not have method `to_i` | ||
| code: Ruby::NoMethod |
There was a problem hiding this comment.
kachick
commented
Jun 1, 2022
Comment on lines
+34
to
+58
| - range: | ||
| start: | ||
| line: 326 | ||
| character: 8 | ||
| end: | ||
| line: 326 | ||
| character: 52 | ||
| severity: ERROR | ||
| message: |- | ||
| UnexpectedError: undefined method `constr' for nil:NilClass | ||
|
|
||
| constr = rhs_result.constr.update_lvar_env do |lvar_env| | ||
| ^^^^^^^ | ||
| code: Ruby::UnexpectedError | ||
| - range: | ||
| start: | ||
| line: 326 | ||
| character: 26 | ||
| end: | ||
| line: 326 | ||
| character: 52 | ||
| severity: ERROR | ||
| message: sclass receiver must be instance type or singleton type, but type given | ||
| `untyped` | ||
| code: Ruby::UnsupportedSyntax |
There was a problem hiding this comment.
Looks intentional omitted 😮
kachick
commented
Jun 20, 2022
Comment on lines
+34
to
+47
| - range: | ||
| start: | ||
| line: 326 | ||
| character: 8 | ||
| end: | ||
| line: 326 | ||
| character: 52 | ||
| severity: ERROR | ||
| message: |- | ||
| UnexpectedError: undefined method `constr' for nil:NilClass | ||
|
|
||
| constr = rhs_result.constr.update_lvar_env do |lvar_env| | ||
| ^^^^^^^ | ||
| code: Ruby::UnexpectedError |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26
Not all for the issue. But I can close major part.