Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @octokit/types from 6.37.0 to 6.37.1 #60

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 27, 2022

Bumps @octokit/types from 6.37.0 to 6.37.1.

Release notes

Sourced from @​octokit/types's releases.

v6.37.1

6.37.1 (2022-06-25)

Bug Fixes

  • RequestInterface: make types with VS Code Typeahead and TypeScript 4.7 (#399) (b5fa0ce)
Commits
  • b5fa0ce fix(RequestInterface): make types with VS Code Typeahead and TypeScript 4.7 (...
  • 38b2189 ci(action): update actions/checkout action to v3 (#401)
  • bc67088 build(deps-dev): bump semantic-release from 18.0.0 to 19.0.3
  • 21e3b89 build(deps): bump semver-regex from 3.1.3 to 3.1.4
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 27, 2022
@kachick
Copy link
Owner

kachick commented Jun 27, 2022

@kachick kachick self-assigned this Jun 27, 2022
@kachick
Copy link
Owner

kachick commented Jun 27, 2022

It now only accepts string for the route param, however looks mistaken. At least they bumped semver:pacth 🤔

@kachick
Copy link
Owner

kachick commented Jun 27, 2022

Looks only happened in octokit.paginate, octokit.request does not accept same arguments 🤔

https://www.npmjs.com/package/@actions/github
https://github.com/actions/toolkit

@kachick
Copy link
Owner

kachick commented Jun 27, 2022

    /**
     * Paginate a request using an endpoint method, parameters, and a map function
     *
     * @param {string} request Request method (`octokit.request` or `@octokit/request`)
     * @param {object} parameters URL, query or body parameters, as well as `headers`, `mediaType.{format|previews}`, `request`, or `baseUrl`.
     * @param {function} mapFn? Optional method to map each response to a custom array
     */
    <R extends OctokitTypes.RequestInterface, M extends unknown[]>(request: R, parameters: Parameters<R>[0], mapFn: MapFunction<NormalizeResponse<OctokitTypes.GetResponseTypeFromEndpointMethod<R>>, M>): Promise<M>;
    /**
     * Paginate a request using an endpoint method and parameters
     *
     * @param {string} request Request method (`octokit.request` or `@octokit/request`)
     * @param {object} parameters? URL, query or body parameters, as well as `headers`, `mediaType.{format|previews}`, `request`, or `baseUrl`.
     */
    <R extends OctokitTypes.RequestInterface>(request: R, parameters?: Parameters<R>[0]): Promise<NormalizeResponse<OctokitTypes.GetResponseTypeFromEndpointMethod<R>>["data"]>;

@kachick
Copy link
Owner

kachick commented Jun 27, 2022

Bumps [@octokit/types](https://github.com/octokit/types.ts) from 6.37.0 to 6.37.1.
- [Release notes](https://github.com/octokit/types.ts/releases)
- [Commits](octokit/types.ts@v6.37.0...v6.37.1)

---
updated-dependencies:
- dependency-name: "@octokit/types"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/octokit/types-6.37.1 branch from 5785401 to 513454d Compare June 28, 2022 00:02
@kachick
Copy link
Owner

kachick commented Jun 28, 2022

I don't want to change using API of paginate, so wait the result of octokit/types.ts#405.
They have been released next minor version. Hmm...

I might call below command twice or more.
@dependabot ignore this minor version

@kachick kachick closed this Jun 28, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 28, 2022

OK, I won't notify you about version 6.37.x again, unless you re-open this PR or update to a 6.37.x release yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant