Let Dependabot handle yarn workspace updates natively #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependabot should know about yarn workspaces and handle updates to those correctly. Because the `cli` folder was handled as a top-level yarn project, PRs to that workspace did not include updates to the lockfile (which lives a directory up, and Dependabot doesn't check there).
|
Hey @jurre! Sorry for seeing your contribution just after pushing the same fix 🤦 Going to close this PR, but feel free to suggest further changes to Dependabot config if you want to experiment with anything! |
|
I can also add you as a collaborator of this repo if you are interested. This way you won't have to wait for my PR approvals and perhaps get |
|
No worries! No need to add me as a collaborator for now I think but thanks for offering! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot should know about yarn workspaces and handle updates to those correctly. Because the
clifolder was handled as a top-level yarn project, PRs to that workspace did not include updates to the lockfile (which lives a directory up, and Dependabot doesn't check there).