This repository has been archived by the owner on Nov 21, 2020. It is now read-only.
Adding the ability to run php-r on Windows #11
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried the old library on a PHP 5.5.12 / Windows 7 setup and a PHP 5.4.12 /Windows 8 setup.When the library would call the stream_set_blocking() method in CommandLineRProcess.php it always return false resulting in PHP to hang when fgets was called in the following line. After reading http://php.net/manual/en/function.stream-set-blocking.php and https://bugs.php.net, it seems that stream_set_blocking() had a problems on Windows machines for a while.
To get around stream_set_blocking(), I had errors written to a file instead of reading them from a pipe.