Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kadalu Storage Volume Rebalance #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Kadalu Storage Volume Rebalance #26

wants to merge 1 commit into from

Conversation

aravindavk
Copy link
Member

Signed-off-by: Aravinda Vishwanathapura mail@aravindavk.in

Copy link
Member

@amarts amarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The plan and design looks neat 👍

kadalu volume rebalance-stop <POOL>/<VOLUME>
----

Above command calls the respective API that internally starts a service in respective Storage unit nodes. **Note**: These services will halt once the Rebalance process completes its job. Do not start the service in every nodes of the Volume, start only in the node of the first Storage unit from each distribute groups.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design is cool 💯
Any reason for the command to be run from node of 1st storage unit from each distribute group. Is it avoid redundancy or wrong calculation of starting point of hash range.

Will it not be feasible to call the command from server node as an option, since moana has server-client model and create a node action to fetch necessary xattr details from nodes of 1st storage unit of dist grp to make it much simpler?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First node is to make it predictable. Any random node is fine, but Moana should keep a reference where it started the service. We can improve this part later. For now it always starts in the first node of every distribute group.

kubectl kadalu rebalance-status <Pool-name>
----

== Tool to handle the rebalance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also contain the migrate data option to remove linkfiles created for renamed files in cached locations or this is part of glusterfs rebalance command itself?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrate data is handled by GlusterFS itself via the exposed virtual xattrs. Rebalance tool only manages the filesystem crawl and calls Rebalance xattrs.

Signed-off-by: Aravinda Vishwanathapura <mail@aravindavk.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants