Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix single quote string grammar #3

Merged
merged 1 commit into from
May 30, 2023
Merged

fix single quote string grammar #3

merged 1 commit into from
May 30, 2023

Conversation

trendzetter
Copy link
Contributor

  • close the string if it's followed by ) otherwise it looks like the ) is part of the string. eg 'blad)
  • closing the single quote string on closing square bracket
  • don't automatically add additional closing quote on typing a single quote

@trendzetter
Copy link
Contributor Author

trendzetter commented May 19, 2023 •
edited
Loading

These fixes were already applied to the grammar in atom-pact extension after this vscode extension was forked from it. So it's basically just syncing up again with upstream.
references from pact-atom:
kadena-io/pact-atom#9
kadena-io/pact-atom#11

@trendzetter trendzetter mentioned this pull request May 30, 2023
Merged
5 tasks
@Randynamic Randynamic merged commit 81b3bb7 into kadena-community:master May 30, 2023
@trendzetter trendzetter mentioned this pull request Jun 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Randynamic Randynamic Randynamic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trendzetter @Randynamic