Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReplSpec tests in GH action #1216

Merged
merged 1 commit into from
May 11, 2023
Merged

Fix ReplSpec tests in GH action #1216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/applications.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ jobs:
run: cabal build
- name: Test
shell: bash
run: cabal test +RTS -N
run: cabal run tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively, since we have some time to look at this deeply, perhaps we should take a look at https://hackage.haskell.org/package/hspec-core-2.11.0.1/docs/Test-Hspec-Core-Spec.html#v:sequential and https://hackage.haskell.org/package/hspec-core-2.11.0.1/docs/Test-Hspec-Core-Spec.html#v:parallel when running these tests in the actual PactTests.hs file, rather than relying on CI to do "the right thing". I'll take a stab at this today and if nothing turns up, let's merge as is, but ideally we'd have these be reproducible at the local level via cabal test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did that analysis turn out, Emily?

Copy link
Member

@emilypi emilypi May 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to say - i can't get anything to trigger locally. I'm tempted to just say "merge this" and then we can re-evaluate later. I don't want to block.

- name: Benchmark
shell: bash
if: "!contains(matrix.flags, '-build-tool')"
Expand Down