-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
read-msg recoverable under some key #1223
Conversation
Some comments via the new template:
Didn't see this in the description
This actually means it does need a replay as any fork could have a bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very straightforward to me. Thank you for the tests!
Fixed, sorry I thought i pasted it
Ah, oops. Yeah it is a semantic change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs replay/justification to not replay + IT and I'll approve
src/Pact/Native/Internal.hs
Outdated
isExecutionFlagSet FlagDisablePact47 >>= \case | ||
True -> | ||
evalError' i $ "No such key in message: " <> pretty k | ||
False -> | ||
failTx' i $ "No such key in message: " <> pretty k |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional suggestion:
isExecutionFlagSet FlagDisablePact47 >>= \case | |
True -> | |
evalError' i $ "No such key in message: " <> pretty k | |
False -> | |
failTx' i $ "No such key in message: " <> pretty k | |
ifExecutionFlagSet FlagDisablePact47 | |
(evalError' i $ "No such key in message: " <> pretty k) | |
(failTx' i $ "No such key in message: " <> pretty k) |
PR checklist:
Additionally, please justify why you should or should not do the following:
Forked. Needs replay
No point in this PR.