Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swapped type assignment in fold symeval #1253

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Fix swapped type assignment in fold symeval #1253

merged 2 commits into from
Jul 18, 2023

Conversation

0xd34df00d
Copy link
Contributor

@0xd34df00d 0xd34df00d commented Jul 17, 2023

Fixes #1249. Also added a test where the accumulator and elements folded over have different types.

No feature flags since that's presumably not needed for FV stuff.


PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issue cabal run tests. If they pass locally, docs are generated.
  • Any changes that could be relevant to users have been recorded in the changelog
  • In case of changes to the Pact trace output (pact -t), make sure pact-lsp is in sync.

Additionally, please justify why you should or should not do the following:

  • Confirm replay/back compat
  • Benchmark regressions
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact

Copy link
Member

@rsoeldner rsoeldner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilypi emilypi merged commit 4426e86 into master Jul 18, 2023
@emilypi emilypi deleted the gr/fv_folds branch July 18, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort mismatch failure
3 participants