strip ALL pact value infos, recursively as well, add tests #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcardon
requested review from
sirlensalot,
jwiegley and
emilypi
as code owners
jmcardon
commented
Aug 21, 2023
| @@ -129,6 +130,14 @@ stripPactValueInfo = \case | |||
| PGuard gu -> PGuard gu | |||
| PModRef mr -> PModRef mr{_modRefInfo = def } | |||
|
|
|||
| stripAllPactValueInfo :: PactValue -> PactValue | |||
| stripAllPactValueInfo = \case | |||
There was a problem hiding this comment.
Note: stripPactValueInfo above isn't even enough, the author of that code did not cover PGuard which can recursively contain pact values, the tests in this PR in hash.repl have a case with a user guard which does indeed fail if not stripped recursively.
| @@ -25,27 +31,39 @@ | |||
| ; pre fork module hashing | |||
| (insert-hash "a" (hash my-mod)) | |||
| (insert-hash "b" (hash my-mod)) | |||
| (insert-hash "c" (hash [my-mod, {'a:my-mod}, (create-user-guard (f my-mod))])) | |||
There was a problem hiding this comment.
this covers all cases recursively for my-mod.
PactValues are:
- lists
- objects
- guards (can contain them recursively too)
- literals
- modrefs
Literals cannot contain any pactvalues, so it's just the other 3 cases we must check.
emilypi
approved these changes
Aug 21, 2023
edmundnoble
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1284 for sample output
PR checklist:
cabal run tests. If they pass locally, docs are generated.pact -t), make sure pact-lsp is in sync.Additionally, please justify why you should or should not do the following: