Fix div by zero in concat gas model
#1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xd34df00d
requested review from
sirlensalot,
jwiegley,
emilypi and
jmcardon
as code owners
0xd34df00d
commented
Nov 4, 2023
| @@ -224,7 +226,7 @@ instance Pretty GasArgs where | |||
| GSelect {} -> "GSelect" | |||
| GSortFieldLookup i -> "GSortFieldLookup:" <> pretty i | |||
| GConcatenation i j -> "GConcatenation:" <> pretty i <> colon <> pretty j | |||
| GTextConcatenation nChars nStrings -> "GTextConcatenation:" <> pretty nChars <> colon <> pretty nStrings | |||
| GTextConcatenation nChars nStrings fixupDiv -> "GTextConcatenation:" <> pretty nChars <> colon <> pretty nStrings <> colon <> pretty fixupDiv | |||
There was a problem hiding this comment.
This assumes changing this Pretty instance doesn't participate in on-chain computations. I skimmed through the code and found no evidence it does, but worth double-checking.
There was a problem hiding this comment.
I'm not sure about this, @jmcardon ?
There was a problem hiding this comment.
It does not. Gas logs are not part of txlog outputs that get hashed.
rsoeldner
reviewed
Nov 4, 2023
| @@ -826,6 +826,12 @@ d.G3 | |||
| (env-gas 0) | |||
| (concat strings_1000_2000) | |||
| (expect "calling (concat strings_1000_2000)" 151 (env-gas)) | |||
|
|
|||
| ;; Test issue #1316 | |||
| (expect "concat gassing works on empty list" "" (concat [])) | |||
edmundnoble
approved these changes
Nov 7, 2023
rsoeldner
approved these changes
Nov 9, 2023
jmcardon
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist:
cabal run tests. If they pass locally, docs are generated.pact -t), make sure pact-lsp is in sync.Additionally, please justify why you should or should not do the following: