Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested groups on server #663

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix nested groups on server #663

wants to merge 1 commit into from

Conversation

koszta
Copy link

@koszta koszta commented Jul 5, 2016

I have multiple nested groups in a project, when on the client I've been using FlowRouter.path() it was working fine (/a/b/c), but on the server it only returned the last group's prefix (/b/c).
It turned out, that on the server the implementation of Group was not up-to-date with the client's implementation.

dr-dimitru added a commit to veliovgroup/flow-router that referenced this pull request Feb 23, 2017
 - Fix nested groups on server, see [PR
kadirahq#663](kadirahq#663)
 - Same behavior for Server groups, as for groups on Client
dr-dimitru added a commit to veliovgroup/flow-router that referenced this pull request Feb 23, 2017
 - Fix for cases when route's param isn't String
 - Fix broken redirects in triggers
 - Fix exception on `new Route()` without arguments
 - Preserve `%` and `+` symbols in URI
 - Allow to use triggersEnter in Group without Array, see [PR
kadirahq#659](kadirahq#659)
 - Fix generation of URLs with a ROOT_URL containing a path, see [PR
kadirahq#691](kadirahq#691)
 - Support RegEx ([0-9]*) in .path, see [PR
kadirahq#654](kadirahq#654)
 - Fix nested groups on server, see [PR
kadirahq#663](kadirahq#663)
 - Same behavior for Server groups, as for groups on Client
 - Add auto-tests
 - NPM Dependencies update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant