Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ability to accept relative paths #75

Closed
wants to merge 1 commit into from

Conversation

gfyoung
Copy link
Contributor

@gfyoung gfyoung commented Nov 3, 2021

Blocking the acceptance of relative paths by throwing errors is a relatively harsh change that has made it difficult for
downstream libraries (e.g., eslint) to upgrade.

Given that relative paths have undefined treatment in ".gitignore" and the usage of this library beyond ".gitignore" behavior, it seems fair to give downstream users the chance to customize the handling of these cases for their own cases.

xref: #20

Blocking the acceptance of relative paths by throwing errors
is a relatively harsh change that has made it difficult for
downstream libraries (e.g., eslint) to upgrade.

Given that relative paths have undefined treatment in ".gitignore"
and the usage of this library beyond ".gitignore" behavior, it seems
fair to give downstream users the chance to customize the handling
of these cases for their own cases.

xref: kaelzhang#20
@gfyoung
Copy link
Contributor Author

gfyoung commented Nov 3, 2021

@kaelzhang: Given what you said a couple of years ago (#20 (comment)), I'm curious what your thoughts are on this now. If you're good with relaxing this requirement via constructor configuration, I'll proceed with test cases.

@gfyoung
Copy link
Contributor Author

gfyoung commented Nov 18, 2021

@kaelzhang: Friendly ping here. Would be helpful to get your thoughts on this before I make this a full PR.

@kaelzhang kaelzhang marked this pull request as ready for review November 19, 2021 07:35
@kaelzhang
Copy link
Owner

close coz of inactivity

@kaelzhang kaelzhang closed this Dec 19, 2021
kaelzhang added a commit that referenced this pull request Dec 19, 2021
@gfyoung gfyoung deleted the ignore-relative branch December 19, 2021 05:16
@gfyoung
Copy link
Contributor Author

gfyoung commented Dec 19, 2021

@kaelzhang : Thanks for pushing these commits.

I missed the notification that you marked this PR as ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants