Feat(event) - added nonInteraction option #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO the flatten-style arguments for ga is a little bit awkward :( var params = {
hitType: 'event',
eventCategory: model.category || DEFAULT_CATEGORY,
eventAction: model.action || DEFAULT_ACTION,
eventLabel: model.label || i13nNode.getText(payload.target) || DEFAULT_LABEL,
eventValue: model.value || 0,
transport: model.transport || 'none',
nonInteraction: model.nonInteraction || false
};
_command.call(this, {
tracker: model.tracker || '',
commandName: 'send',
arguments: [params]
}); |
| @@ -91,6 +91,11 @@ ReactI13nGoogleAnalytics.prototype.getPlugin = function () { | |||
| if (model.value) { | |||
| params.push(model.value); | |||
| } | |||
| if (model.nonInteraction) { | |||
There was a problem hiding this comment.
yeah will something be broken if value doesn't exist but nonInteraction does?
There was a problem hiding this comment.
@adlenafane hi any update for this?
adlenafane
force-pushed
the
feat-params-nonInteraction
branch
from
88cc783
to
71d96b4
Compare
|
@hero78119 @kaesonho I did a bit of refacto to use the ga fieldsObject :) |
|
thanks for the update 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the non-interaction events https://developers.google.com/analytics/devguides/collection/analyticsjs/events#non-interaction_events
@kaesonho I'm not sure about how you would like to implement this. Could you review please?