-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set environment variables from secretRef/configMap #17
Conversation
…secretKeyRef/configMapKeyRef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort
@chrbrnracn thanks for your contribution! |
@chrbrnracn did you check it? |
Did I check what? It's working fine for me. |
values.yaml:
@chrbrnracn do you see the problem at first glance? |
Current situation:
With the change it is possible to set a named environment variable to a specific key in a specific secret or config map.
Use case:
When running Kafka with Strimzi, each KafkaUser entity gets its own secret with the password and sasl.jaas.config. With the new feature it's possible to directly access this secret and use it for Kafka UI.
There may be a lot more use cases for this feature. That's why I added the same for configMapKeyRef.
Side note:
I had to set all other
kafka.clusters.*
values as envs.config instead of using yamlApplicationConfig, but notauth.*
ormanagement.*
. It looks like the application does not deep-merge values from config file and YAML configuration. I didn't find this in the docs.