Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topics: Fix config fetch for Azure EH #105

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Topics: Fix config fetch for Azure EH #105

merged 2 commits into from
Feb 17, 2024

Conversation

Haarolean
Copy link
Member

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added scope/backend Related to backend changes type/bug Something isn't working labels Feb 5, 2024
@Haarolean Haarolean requested a review from iliax February 5, 2024 21:59
@Haarolean Haarolean self-assigned this Feb 5, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress type/feature A brand new feature status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Feb 5, 2024
@Haarolean Haarolean removed type/feature A brand new feature status/triage/manual Manual triage in progress labels Feb 5, 2024
@Haarolean Haarolean merged commit ccf3103 into main Feb 17, 2024
38 of 42 checks passed
@Haarolean Haarolean deleted the issues/104 branch February 17, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend Related to backend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topics: Azure: Unable to get topic configs if one topic does not have sufficient permissions
2 participants