Skip to content

Issue_528_style_table_column_width #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+102 −22
Open

Issue_528_style_table_column_width #1145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bfd59a
feat: Add BreakableTextCell
Vixtir Jun 18, 2025
1e41747
feat: Add columns sizes
Vixtir Jun 18, 2025
4018b30
FE: Set width for columns, fix header background color
Vixtir Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions frontend/src/components/ACLPage/List/List.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import ACLFormContext from 'components/ACLPage/Form/AclFormContext';
import PlusIcon from 'components/common/Icons/PlusIcon';
import ActionButton from 'components/common/ActionComponent/ActionButton/ActionButton';
import ResourcePageHeading from 'components/common/ResourcePageHeading/ResourcePageHeading';
import BreakableTextCell from 'components/common/NewTable/BreakableTextCell';

import * as S from './List.styled';

Expand Down Expand Up @@ -56,6 +57,7 @@ const ACList: React.FC = () => {
header: 'Principal',
accessorKey: 'principal',
size: 257,
cell: BreakableTextCell,
},
{
header: 'Resource',
Expand Down
3 changes: 2 additions & 1 deletion frontend/src/components/Brokers/BrokersList/lib/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import * as Cell from 'components/Brokers/BrokersList/TableCells/TableCells';
import { createColumnHelper } from '@tanstack/react-table';
import { keyBy } from 'lib/functions/keyBy';
import SkewHeader from 'components/Brokers/BrokersList/SkewHeader/SkewHeader';
import BreakableTextCell from 'components/common/NewTable/BreakableTextCell';

import { BrokersTableRow } from './types';
import { NA_DISK_USAGE } from './constants';
Expand Down Expand Up @@ -75,6 +76,6 @@ export const getBrokersTableColumns = () => {
cell: Cell.Skew,
}),
columnHelper.accessor('port', { header: 'Port' }),
columnHelper.accessor('host', { header: 'Host' }),
columnHelper.accessor('host', { header: 'Host', cell: BreakableTextCell }),
];
};
11 changes: 8 additions & 3 deletions frontend/src/components/Connect/List/List.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { FullConnectorInfo } from 'generated-sources';
import { useConnectors } from 'lib/hooks/api/kafkaConnect';
import { ColumnDef } from '@tanstack/react-table';
import { useNavigate, useSearchParams } from 'react-router-dom';
import BreakableTextCell from 'components/common/NewTable/BreakableTextCell';

import ActionsCell from './ActionsCell';
import TopicsCell from './TopicsCell';
Expand All @@ -22,10 +23,14 @@ const List: React.FC = () => {

const columns = React.useMemo<ColumnDef<FullConnectorInfo>[]>(
() => [
{ header: 'Name', accessorKey: 'name' },
{ header: 'Connect', accessorKey: 'connect' },
{ header: 'Name', accessorKey: 'name', cell: BreakableTextCell },
{ header: 'Connect', accessorKey: 'connect', cell: BreakableTextCell },
{ header: 'Type', accessorKey: 'type' },
{ header: 'Plugin', accessorKey: 'connectorClass' },
{
header: 'Plugin',
accessorKey: 'connectorClass',
cell: BreakableTextCell,
},
{ header: 'Topics', cell: TopicsCell },
{ header: 'Status', accessorKey: 'status.state', cell: TagCell },
{ header: 'Running Tasks', cell: RunningTasksCell },
Expand Down
6 changes: 6 additions & 0 deletions frontend/src/components/ConsumerGroups/List.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ const List = () => {
// eslint-disable-next-line react/no-unstable-nested-components
cell: ({ getValue }) => (
<LinkCell
style={{ wordBreak: 'break-word', whiteSpace: 'pre-wrap' }}
value={`${getValue<string | number>()}`}
to={encodeURIComponent(`${getValue<string | number>()}`)}
/>
Expand All @@ -51,11 +52,13 @@ const List = () => {
id: ConsumerGroupOrdering.MEMBERS,
header: 'Num Of Members',
accessorKey: 'members',
size: 140,
},
{
id: ConsumerGroupOrdering.TOPIC_NUM,
header: 'Num Of Topics',
accessorKey: 'topics',
size: 140,
},
{
id: ConsumerGroupOrdering.MESSAGES_BEHIND,
Expand All @@ -64,11 +67,13 @@ const List = () => {
cell: (args) => {
return args.getValue() ?? 'N/A';
},
size: 124,
},
{
header: 'Coordinator',
accessorKey: 'coordinator.id',
enableSorting: false,
size: 104,
},
{
id: ConsumerGroupOrdering.STATE,
Expand All @@ -85,6 +90,7 @@ const List = () => {
/>
);
},
size: 124,
},
],
[]
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/Dashboard/ClusterName.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ type ClusterNameProps = CellContext<Cluster, unknown>;
const ClusterName: React.FC<ClusterNameProps> = ({ row }) => {
const { readOnly, name } = row.original;
return (
<>
<div style={{ wordBreak: 'break-word', whiteSpace: 'pre-wrap' }}>
{readOnly && <Tag color="blue">readonly</Tag>}
{name}
</>
</div>
);
};

Expand Down
31 changes: 25 additions & 6 deletions frontend/src/components/Dashboard/Dashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,38 @@ const Dashboard: React.FC = () => {
const columns = React.useMemo<ColumnDef<Cluster>[]>(() => {
const initialColumns: ColumnDef<Cluster>[] = [
{ header: 'Cluster name', accessorKey: 'name', cell: ClusterName },
{ header: 'Version', accessorKey: 'version' },
{ header: 'Brokers count', accessorKey: 'brokerCount' },
{ header: 'Partitions', accessorKey: 'onlinePartitionCount' },
{ header: 'Topics', accessorKey: 'topicCount' },
{ header: 'Production', accessorKey: 'bytesInPerSec', cell: SizeCell },
{ header: 'Consumption', accessorKey: 'bytesOutPerSec', cell: SizeCell },
{ header: 'Version', accessorKey: 'version', size: 100 },
{
header: 'Brokers count',
accessorKey: 'brokerCount',
size: 120,
},
{
header: 'Partitions',
accessorKey: 'onlinePartitionCount',
size: 100,
},
{ header: 'Topics', accessorKey: 'topicCount', size: 80 },
{
header: 'Production',
accessorKey: 'bytesInPerSec',
cell: SizeCell,
size: 100,
},
{
header: 'Consumption',
accessorKey: 'bytesOutPerSec',
cell: SizeCell,
size: 116,
},
];

if (appInfo.hasDynamicConfig) {
initialColumns.push({
header: '',
id: 'actions',
cell: ClusterTableActionsCell,
size: 140,
});
}

Expand Down
5 changes: 3 additions & 2 deletions frontend/src/components/KsqlDb/TableView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React from 'react';
import { KsqlStreamDescription, KsqlTableDescription } from 'generated-sources';
import Table from 'components/common/NewTable';
import { ColumnDef } from '@tanstack/react-table';
import BreakableTextCell from 'components/common/NewTable/BreakableTextCell';

interface TableViewProps {
fetching: boolean;
Expand All @@ -13,8 +14,8 @@ const TableView: React.FC<TableViewProps> = ({ fetching, rows }) => {
ColumnDef<KsqlTableDescription | KsqlStreamDescription>[]
>(
() => [
{ header: 'Name', accessorKey: 'name' },
{ header: 'Topic', accessorKey: 'topic' },
{ header: 'Name', accessorKey: 'name', cell: BreakableTextCell },
{ header: 'Topic', accessorKey: 'topic', cell: BreakableTextCell },
{ header: 'Key Format', accessorKey: 'keyFormat' },
{ header: 'Value Format', accessorKey: 'valueFormat' },
{
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/NavBar/NavBar.styled.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const Navbar = styled.nav(
left: 0;
right: 0;
z-index: 30;
background-color: ${theme.menu.primary.backgroundColor.normal};
background-color: ${theme.menu.header.backgroundColor};
min-height: 3.25rem;
`
);
Expand Down
13 changes: 9 additions & 4 deletions frontend/src/components/Schemas/List/List.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,20 @@ const List: React.FC = () => {
// eslint-disable-next-line react/no-unstable-nested-components
cell: ({ getValue }) => (
<LinkCell
style={{ wordBreak: 'break-word', whiteSpace: 'pre-wrap' }}
value={`${getValue<string | number>()}`}
to={encodeURIComponent(`${getValue<string | number>()}`)}
/>
),
},
{ header: 'Id', accessorKey: 'id' },
{ header: 'Type', accessorKey: 'schemaType' },
{ header: 'Version', accessorKey: 'version' },
{ header: 'Compatibility', accessorKey: 'compatibilityLevel' },
{ header: 'Id', accessorKey: 'id', size: 120 },
{ header: 'Type', accessorKey: 'schemaType', size: 120 },
{ header: 'Version', accessorKey: 'version', size: 120 },
{
header: 'Compatibility',
accessorKey: 'compatibilityLevel',
size: 160,
},
],
[]
);
Expand Down
6 changes: 6 additions & 0 deletions frontend/src/components/Topics/List/TopicTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,13 @@ const TopicTable: React.FC = () => {
id: TopicColumnsToSort.TOTAL_PARTITIONS,
header: 'Partitions',
accessorKey: 'partitionCount',
size: 100,
},
{
id: TopicColumnsToSort.OUT_OF_SYNC_REPLICAS,
header: 'Out of sync replicas',
accessorKey: 'partitions',
size: 154,
cell: ({ getValue }) => {
const partitions = getValue<Topic['partitions']>();
if (partitions === undefined || partitions.length === 0) {
Expand All @@ -64,11 +66,13 @@ const TopicTable: React.FC = () => {
header: 'Replication Factor',
accessorKey: 'replicationFactor',
enableSorting: false,
size: 148,
},
{
header: 'Number of messages',
accessorKey: 'partitions',
enableSorting: false,
size: 146,
cell: ({ getValue }) => {
const partitions = getValue<Topic['partitions']>();
if (partitions === undefined || partitions.length === 0) {
Expand All @@ -83,12 +87,14 @@ const TopicTable: React.FC = () => {
id: TopicColumnsToSort.SIZE,
header: 'Size',
accessorKey: 'segmentSize',
size: 100,
cell: SizeCell,
},
{
id: 'actions',
header: '',
cell: ActionsCell,
size: 60,
},
],
[]
Expand Down
6 changes: 5 additions & 1 deletion frontend/src/components/Topics/List/TopicTitleCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ export const TopicTitleCell: React.FC<CellContext<Topic, unknown>> = ({
}) => {
const { internal, name } = original;
return (
<NavLink to={name} title={name}>
<NavLink
to={name}
title={name}
style={{ wordBreak: 'break-word', whiteSpace: 'pre-wrap' }}
>
{internal && (
<>
<Tag color="gray">IN</Tag>
Expand Down
17 changes: 17 additions & 0 deletions frontend/src/components/common/NewTable/BreakableTextCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import React from 'react';
import { CellContext } from '@tanstack/react-table';

const BreakableTextCell = <T,>({ getValue }: CellContext<T, unknown>) => {
return (
<div
style={{
wordBreak: 'break-word',
whiteSpace: 'pre-wrap',
}}
>
{getValue<string>()}
</div>
);
};

export default BreakableTextCell;
12 changes: 10 additions & 2 deletions frontend/src/components/common/NewTable/LinkCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,18 @@ import React from 'react';
import { NavLink } from 'react-router-dom';

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const LinkCell = ({ value, to = '' }: any) => {
const LinkCell = ({
value,
to = '',
style = {},
}: {
value: string;
to?: string;
style?: React.CSSProperties;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my opinion it is not a good idea to pass style to UI components , it is much better approach to have that configured by props

in this case we can have a single prop called wordBreak or something that add those two properties

Copy link
Contributor Author

@Vixtir Vixtir Jun 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used it due to Table.styled.ts has more specific selector for a tag styles white-space: nowrap;

What do you think about using !important

Smth like

const NavLinkStyled = styled(NavLink)<{ $wordBreak?: boolean }>`
  ${({ $wordBreak }) => {
    if ($wordBreak) {
      return css`
        word-break: break-word !important;
        white-space: pre-wrap !important;
      `;
    }
  }}
`;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or that will work too

const NavLinkStyled = styled(NavLink)<{ $wordBreak?: boolean }>`
  && {
    ${({ $wordBreak }) =>
      $wordBreak &&
      css`
        word-break: break-word;
        white-space: pre-wrap;
      `}
  }
`;

}) => {
const handleClick: React.MouseEventHandler = (e) => e.stopPropagation();
return (
<NavLink to={to} title={value} onClick={handleClick}>
<NavLink to={to} title={value} onClick={handleClick} style={style}>
{value}
</NavLink>
);
Expand Down
6 changes: 6 additions & 0 deletions frontend/src/theme/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,6 +566,9 @@ export const theme = {
},
},
menu: {
header: {
backgroundColor: Colors.brand[0],
},
primary: {
backgroundColor: {
normal: 'transparent',
Expand Down Expand Up @@ -1098,6 +1101,9 @@ export const darkTheme: ThemeType = {
},
},
menu: {
header: {
backgroundColor: Colors.brand[90],
},
primary: {
backgroundColor: {
normal: 'transparent',
Expand Down
Loading