-
-
Notifications
You must be signed in to change notification settings - Fork 173
FE: Messages: impl message reproduce #1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi benaskiburtas! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
f1bdefb
to
d7f7748
Compare
Hi @Haarolean, this PR has been open for some time now. Is there anything else I should address, or would it help to have another reviewer take a look? |
@kafbat/frontend PTAL |
What changes did you make? (Give an overview)
Resolves #247

Added a new action to the message action dropdown as suggested on #247:
This is implemented via a hook
useProduceMessage
andTopicActionsContext
to interact with the side-bar while avoiding prop drilling.Action will prefill:
SendMessage.tsx had some aria labels misconfigured, adjusted some properties slightly to point to actual labels.
Is there anything you'd like reviewers to focus on?
ResourceType.TOPIC
&Action.MESSAGES_PRODUCE
permissions, same as the existing standalone action. The initial issue description suggested a new permission specifically for reproducing a message (e.g.Action.MESSAGES_REPRODUCE
?). Do let me know if that would be preferred; :)How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)
