Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wizard: Add an ability to delete clusters from UI #154

Merged
merged 6 commits into from
Mar 17, 2024
Merged

Wizard: Add an ability to delete clusters from UI #154

merged 6 commits into from
Mar 17, 2024

Conversation

Nilumilak
Copy link
Member

@Nilumilak Nilumilak commented Feb 19, 2024 •
edited
Loading

  • Added delete Button
  • useUpdateAppConfig changed to delete clusters

resolves #65

@Nilumilak Nilumilak added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes status/triage/completed Automatic triage completed labels Feb 19, 2024
@Nilumilak Nilumilak requested a review from Mgrdich February 19, 2024 12:39
@Nilumilak Nilumilak self-assigned this Feb 19, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress area/wizard UI configuration wizard issues and removed status/triage Issues pending maintainers triage labels Feb 19, 2024
@Nilumilak
Wizard: Add an ability to delete clusters from UI
657ea54 
+ Added delete Button
+ useUpdateAppConfig changed to delete clusters

Resolves Issue #65
@Nilumilak Nilumilak force-pushed the feature/delete_cluster branch from 32b90bf to 657ea54 Compare February 20, 2024 06:58
@Haarolean Haarolean removed the status/triage/manual Manual triage in progress label Feb 21, 2024
Nilumilak and others added 2 commits February 29, 2024 10:04
@Nilumilak
Wizard: Add an ability to delete clusters from UI
4560f10 
+ removed unnecessary if statement
+ some logic was decomposed

Resolves Issue #65
@Haarolean
Merge branch 'main' into feature/delete_cluster
e0ba24a
@Nilumilak Nilumilak requested a review from Mgrdich March 4, 2024 10:27
@Nilumilak Nilumilak requested a review from a team as a code owner March 16, 2024 19:48
@Haarolean Haarolean enabled auto-merge (squash) March 16, 2024 19:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Haarolean Haarolean disabled auto-merge March 17, 2024 12:10
@Haarolean Haarolean merged commit 1c71043 into main Mar 17, 2024
9 of 12 checks passed
@Haarolean Haarolean deleted the feature/delete_cluster branch March 17, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mgrdich Mgrdich Mgrdich approved these changes

@Haarolean Haarolean Haarolean approved these changes

Assignees

@Nilumilak Nilumilak

Labels
area/wizard UI configuration wizard issues scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wizard: Add an ability to delete clusters from UI
3 participants
@Nilumilak @Haarolean @Mgrdich