Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Add forms for an ACL creating #188

Merged
merged 19 commits into from
Mar 18, 2024
Merged

FE: Add forms for an ACL creating #188

merged 19 commits into from
Mar 18, 2024

Conversation

Vixtir
Copy link
Contributor

@Vixtir Vixtir commented Mar 4, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

  • Add forms for 4 different(custom, for consumer, for producer, for kafka app) types of ACL form

Is there anything you'd like reviewers to focus on?

  • New Radio component
  • Not all code covered by test, some business rules are not opaque ( will add more test iteratively)

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress area/acl status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Mar 4, 2024
@Vixtir Vixtir requested a review from Mgrdich March 4, 2024 10:22
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes and removed status/triage/manual Manual triage in progress labels Mar 4, 2024
Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can we use the same type of button as in topics? Current one has a weird shape of a plus sign
image image
  1. The form is quite unreadable with the dark theme
image
  1. Can we please make the table sortable? Via our default sorting logic, for starters.
  2. Checked checkmark has the blue background, doesn't math our new grey shade theme
image
  1. "prefixed" input doesn't have the "prefix..." tooltip in some tabs
image

TODO Backend: We'd need to fix some 500s on the backend which we get in case of some fields don't pass the validation

@Vixtir Vixtir requested a review from a team as a code owner March 17, 2024 10:59
@Vixtir Vixtir requested a review from Mgrdich March 17, 2024 11:07
@Haarolean Haarolean linked an issue Mar 17, 2024 that may be closed by this pull request
@Haarolean Haarolean self-requested a review March 18, 2024 17:18
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Haarolean Haarolean merged commit 6b7fda4 into main Mar 18, 2024
8 of 9 checks passed
@Haarolean Haarolean deleted the feature/acl/rw branch March 18, 2024 17:45
@Haarolean Haarolean added type/feature A brand new feature and removed type/enhancement En enhancement/improvement to an already existing feature labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/acl scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/feature A brand new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: ACL management
3 participants