-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infra: Ensure image arch automatic inference #378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi hugomiguelabreu! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
I am not sure about the image used as I wasn't able to infer the actual version from the hash. I based off the latest one, locking the hotfix. Let me know if we need some other particular version to be compliant with any active CVE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you , this will be really helpful
the point was pinning the version, but your solution is better, I guess, since the minor version won't get updated either :) This should work generally, unless we have to bump the version before a minor is released to circumvent any CVEs in alpine. Thanks! |
What changes did you make? (Give an overview)
Changes the base image used to ensure automatic inference, guaranteeing a correct base image for the built kafka-ui one.
Building the image with the updated base one the container boots successfully.
Closes: #376
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)