Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Messages: Allow searching in message headers #695

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

yeikel
Copy link
Contributor

@yeikel yeikel commented Dec 6, 2024

What changes did you make? (Give an overview)

Closes #687

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • Unit checks

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

image

@yeikel yeikel requested a review from a team as a code owner December 6, 2024 01:37
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Dec 6, 2024
@yeikel yeikel changed the title include headers during search FE: include headers during search Dec 6, 2024
@yeikel yeikel changed the title FE: include headers during search FE: include message headers during search Dec 6, 2024
@yeikel yeikel marked this pull request as draft December 6, 2024 01:37
@yeikel yeikel force-pushed the fix/message-headers branch 2 times, most recently from f5e4eb4 to e391974 Compare December 6, 2024 01:44
@yeikel yeikel marked this pull request as ready for review December 6, 2024 01:52
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes area/messages and removed status/triage/manual Manual triage in progress labels Dec 7, 2024
@Haarolean Haarolean changed the title FE: include message headers during search BE: Messages: Allow searching in message headers Dec 7, 2024
@yeikel yeikel force-pushed the fix/message-headers branch from e391974 to 5d8b666 Compare December 7, 2024 18:03
@yeikel
Copy link
Contributor Author

yeikel commented Dec 7, 2024

@Haarolean Thank you for reviewing it

I believe that the E2E test failures are unrelated?

Is there anything else pending to merge this?

@Haarolean Haarolean merged commit 3c0cd73 into kafbat:main Dec 8, 2024
11 of 13 checks passed
@Haarolean
Copy link
Member

@yeikel yeah, there's one flaky test. Thanks for another contribution!

@yeikel
Copy link
Contributor Author

yeikel commented Dec 8, 2024

@yeikel yeah, there's one flaky test. Thanks for another contribution!

Thank you for merging it :)

@yeikel yeikel deleted the fix/message-headers branch December 8, 2024 19:37
K-Diger pushed a commit to K-Diger/kafbat-kafka-ui that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/messages scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messages: Allow searching in message headers
2 participants