Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CEL as a replacement for Groovy message filters #98

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

DementevNikita
Copy link
Contributor

@DementevNikita DementevNikita commented Feb 4, 2024

Closes: #63

This is a naive and intermediate implementation that doesn't address CEL null-check "problems"

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

This is a naive and intermediate implementation that doesn't address CEL null-check "problems"
@DementevNikita DementevNikita self-assigned this Feb 4, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress labels Feb 4, 2024
@kapybro kapybro bot assigned Haarolean and unassigned DementevNikita Feb 4, 2024
@kapybro kapybro bot added type/feature A brand new feature status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Feb 4, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there DementevNikita! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

… filters

Top-level variable 'record' is now used to write message filters with, e.g. 'record.offset != 100'
@iliax iliax requested review from iliax and removed request for Haarolean February 10, 2024 16:23
@Haarolean Haarolean added the scope/backend Related to backend changes label Feb 10, 2024
@Haarolean Haarolean merged commit 11a57d1 into main Feb 10, 2024
9 of 13 checks passed
@Haarolean Haarolean deleted the bugfix/replace_groovy_filters_with_cel branch February 10, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend Related to backend changes status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress type/feature A brand new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace groovy filters with CEL
3 participants