-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: add telemetry #512
base: dev/telemetry
Are you sure you want to change the base?
WIP: add telemetry #512
Conversation
]}, | ||
{erl_opts, [warnings_as_errors, {d, build_brod_cli}]} | ||
{erl_opts, [warnings_as_errors, {d, build_brod_cli}, {d, brod_use_telemetry}]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm convinced this is not necessary.
Please remove it.
Thanks for the PR. BTW. I originally wanted a solution without |
I have changed the base to |
This would be very nice to have. What is needed to get this in? |
👋 Also looking to help push this forward, @zmstone , how can I help? |
Use dependency injection. |
No description provided.