SchemaRegistry: Add http agent argument #108
Conversation
Add option to pass in HTTP agent that binds to mappersmith
seriouslag
force-pushed
the
feature/schemaRegistry/add-http-agent-arg
branch
from
de7f49e
to
27b0b8a
Compare
src/api/index.ts
Outdated
| forge({ | ||
| agent, | ||
| }: SchemaRegistryAPIClientArgs): SchemaRegistryAPIClient => { | ||
| // TODO: figure out how to only bind agent to host URL |
There was a problem hiding this comment.
So the way you'd do this is to pass in the gatewayConfigs as a property of the manifest (what gets passed into forge). That way we don't change the gateway configs globally, only for this client.
There was a problem hiding this comment.
There was a problem hiding this comment.
I was having issues with the typings of mappersmith (and prettier... forcing a semicolon before parentheses 🤷♂️). From looking at the code I believe the latest changes are as mappersmith needs from a config.
There was a problem hiding this comment.
Opened a PR in mappersmith to avoid having to do the gnarly casting to any. tulios/mappersmith#211
Let's merge this anyway and then we can hopefully remember to go back and fix this once a new version of mappersmith is out.
|
This is a very useful change that I'd like to get merged. I only have one comment, to make sure that we don't modify the global gateway config. Other than that it's great. |
Add option to pass in HTTP agent that binds to mappersmith
…ithub.com/seriouslag/confluent-schema-registry into feature/schemaRegistry/add-http-agent-arg
seriouslag
force-pushed
the
feature/schemaRegistry/add-http-agent-arg
branch
from
2428a31
to
d2354ec
Compare
src/api/index.ts
Outdated
| if (agent) { | ||
| // gatewayConfigs is not listed as a type on manifest object in mappersmith | ||
| ;(manifest as any).gatewayConfigs = { | ||
| configure: () => agent, |
There was a problem hiding this comment.
| configure: () => agent, | |
| configure: () => ({ agent }), |
See here for an example: https://github.com/tulios/mappersmith#http
There was a problem hiding this comment.
I'm useless without my types (and coffee...). Good catch! Updated.
Add option to pass in HTTP agent that binds to mappersmith