Handle Ajv backwards incompatible changes between 7 and 8 #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of the Ajv constructor aren't compatible with the version we're using. Since we only care about the compile method, we can require just that.
Newer versions of Ajv have made backwards incompatible changes to the validation errors, so we have to have our own type that only requires the things we need, and then handle both possible types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v3.1.0 we allow passing an Ajv instance in the constructor parameters. However, because we require it to be an instance of
Ajv, and Ajv made backwards incompatible changes in version 8, it means that you cannot use that version with this package.Our interface towards Ajv is actually quite small. We only ever use the
compilemethod and the error type that we get back. The error type unfortunately had some backwards incompatible changes that affected us, so I had to write a small compatibility shim to construct our error from either version.