Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove carat version for jest types #29

Merged
merged 2 commits into from
Nov 28, 2019
Merged

Conversation

erikengervall
Copy link
Collaborator

No description provided.

@erikengervall erikengervall merged commit a34eb46 into master Nov 28, 2019
@erikengervall erikengervall deleted the fix-broken-jest-types branch November 28, 2019 08:31
@sidharthv96
Copy link

Are you sure changing the version of @types/jest to a fixed one is the right solution?
I mentioned that only as a temporary workaround.
That doesn't resolve the root cause of the issue right?

@erikengervall
Copy link
Collaborator Author

Are you sure changing the version of @types/jest to a fixed one is the right solution?
I mentioned that only as a temporary workaround.
That doesn't resolve the root cause of the issue right?

It doesn't address the root cause, but it caused serious issues in projects in which it was used so this is an intermediate solution until there's an official fix and/or it's possible to resolve on our own.

I'll create a new issue regarding this so that we remember to fix it properly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants