[Bug]: cue indexing recognized some of cue file，but some not.

[Linxuanhua1]

What happened?

Not all of cue files are recognized correctly. The files encoded with utf8-bom aren't recognized. Does the programme not support this format?

Steps to reproduce

Normally run docker version with enabling cue indexing.

Version

latest docker

Version Detail

No response

Operating System

Linux

Java Version

docker included

Database

Other

DB Detail

No response

Configuration paramter

Normal

Proxy Server

No response

client detail

No response

language

None

Relevant log output

No response

[yuygfgg]

could you please provide a sample cue file?

[Linxuanhua1]

could you please provide a sample cue file?

KSLA-0001.zip

[Linxuanhua1]

could you please provide a sample cue file?

I found that some utf8-bom cue files were correctly recognized, but others were not. It's quite amazing

[UVJkiNTQ]

could you please provide a sample cue file?

I found that some utf8-bom cue files were correctly recognized, but others were not. It's quite amazing

I tried with the edge build and found all cues recogniztion are failed.

[UVJkiNTQ]

airsonic.log
log attached

[UVJkiNTQ]

cd6b824
This problem was introduced in this commit.
I tested former builds and that is okay.

[yuygfgg]

I'm quite confident that snapshots after cd6b824 still works, at least those during May 2024. However, I'm not sure about later builds because I no longer have cue indexed audios.

[yuygfgg]

@kagemomiji Could you please take a look? This seems to be an issue with wide-ranging implications.

[yuygfgg]

Only UTF-8 without BOM works

[kagemomiji]

@Linxuanhua1 @UVJkiNTQ @yuygfgg
I have created fixed docker image. Could you try ghcr.io/kagemomiji/airsonic-advanced:pr-636?

[UVJkiNTQ]

@Linxuanhua1 @UVJkiNTQ @yuygfgg I have created fixed docker image. Could you try ghcr.io/kagemomiji/airsonic-advanced:pr-636?

I will try

[Linxuanhua1]

@Linxuanhua1 @UVJkiNTQ @yuygfgg I have created fixed docker image. Could you try ghcr.io/kagemomiji/airsonic-advanced:pr-636?

ok, I will try it now!!!!!

[UVJkiNTQ]

Seems okay for me in library recognization.
I will further test with palylist containing cue.

[Linxuanhua1]

awesome!! Thanks!! It works!!

[UVJkiNTQ]

Thanks for the fix.

I further tried with m3u file containing cue path.

The file parsing seems okay but the 'extraction' of the play items is failed and I got a 'missing' tag.
test.m3u.txt

Maybe this kind of playlist is not supported yet?

[kagemomiji]

@UVJkiNTQ
No, Airsonic Advanced does not support M3U files that include CUE files.

Thanks for the fix.

I further tried with m3u file containing cue path.

The file parsing seems okay but the 'extraction' of the play items is failed and I got a 'missing' tag. test.m3u.txt

Maybe this kind of playlist is not supported yet?

[UVJkiNTQ]

Increased the library size and found more cues errors.
Error parsing:
KSLA-1009.cue.txt

This is okay:
KSLA-1008.cue.txt

I'm quite confusing about the difference.

[UVJkiNTQ]

Further tested with 11.1.3-SNAPSHOT.20230429160252 and that is okay. It is tricky now.

[kagemomiji]

@UVJkiNTQ
It seems that the CUE Sheets you cannot load have issues with their formatting, preventing them from being processed correctly.
I have implemented a feature to output a warning message whenever a CUE Sheet fails to load.
Please pull pr-636 image again and check the warning message and adjust the CUE Sheet accordingly.

[UVJkiNTQ]

@UVJkiNTQ
It seems that the CUE Sheets you cannot load have issues with their formatting, preventing them from being processed correctly.
I have implemented a feature to output a warning message whenever a CUE Sheet fails to load.
Please pull pr-636 image again and check the warning message and adjust the CUE Sheet accordingly.

Thanks for your effort.
I will try it.
Btw, is it possible to have a seperate tool to do the validation just under the folder with the same parsing method? That might be more straightforward.

[UVJkiNTQ]

CUEs.zip
airsonic.log
Tested with small samples.
@kagemomiji
These are the results:

1. The field is too long to burn as CD-TEXT. The maximum length is 80.

This seems just a warning, parsing is okay.
Update: It affacts.

2. Wrong number of digits in number

Error parsing. The time code is larger than 99 is first field.

TRACK 22 AUDIO
TITLE "Highest Life"
INDEX 01 108:48:69

3. Could not find base file 'Lia - Heartily Song.flac' for cue sheet [KSLM-0099]『Heartily Song』[flac+cue+log+png]/Lia - Heartily Song.flac
   Error parsing. The file is there in actual.

4. Invalid position. First index must have position 00:00:00
   I have no idea about this. CUEs attached.
   Error parsing.

5. Unparseable line. Will ignore
   This is actual regain info. REM REPLAYGAIN_TRACK_GAIN -10.4 dB
   Error parsing.
   ReplayGain

6. Empty lines not allowed. Will ignore
   Extra empty lines at the end of file. This is quite normal in early output of ripping tools like EAC,
   Error parsing.

7. Invalid catalog number and ISRC code has noncompliant format
   Error parsing.
   It seems some rippers will edit manually and fill in with 品番. It might be not so strictly defined.

REM GENRE Anime
REM DATE 2007
REM DISCID 2903F504
REM COMMENT ExactAudioCopy v1.5
CATALOG ZMCZ-3325

REM GENRE JPop
REM DATE 2013
REM DISCID 1E032703
REM COMMENT "ExactAudioCopy v1.0b3"
CATALOG 4943674138814
PERFORMER "きゃりーぱみゅぱみゅ"
TITLE "にんじゃりばんばん"
FILE "きゃりーぱみゅぱみゅ - にんじゃりばんばん.flac" WAVE
TRACK 01 AUDIO
TITLE "にんじゃりばんばん"
PERFORMER "きゃりーぱみゅぱみゅ"
ISRC JPV<01370323
INDEX 01 00:00:00
TRACK 02 AUDIO
TITLE "Unite Unite"
PERFORMER "きゃりーぱみゅぱみゅ"
ISRC JPV<01370324
INDEX 00 04:26:42
INDEX 01 04:26:53
TRACK 03 AUDIO
TITLE "みんなのうた -extended mix-"
PERFORMER "きゃりーぱみゅぱみゅ"
ISRC JPV<01370325
INDEX 01 07:40:20

Extra:
All these cues passed foobar2000 rendering.

[kagemomiji]

@UVJkiNTQ
Thank you for providing the information.

I plan to implement an extended functionality to parse CUE Sheets using this new data.
For now, I will close this issue and address it in a new issue #640 .