Skip to content

fix(controller): ensure log level is respected #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EItanya merged 4 commits into from
Dec 1, 2025
Merged

fix(controller): ensure log level is respected #1135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae1866d
fix(controller): remove forced development logging
onematchfox Sep 3, 2025
b82617c
refactor(controller): remove duplicate startup logs
onematchfox Nov 26, 2025
4241a4f
build: set controller loglevel to debug when running locally
onematchfox Nov 26, 2025
e640f15
fix(helm): remove unused env var
onematchfox Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ helm-install-provider: helm-version check-api-key
--set registry=$(DOCKER_REGISTRY) \
--set imagePullPolicy=Always \
--set tag=$(VERSION) \
--set controller.loglevel=debug \
--set controller.image.pullPolicy=Always \
--set ui.image.pullPolicy=Always \
--set controller.service.type=LoadBalancer \
Expand Down
14 changes: 3 additions & 11 deletions go/pkg/app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,6 @@ func init() {
utilruntime.Must(v1alpha1.AddToScheme(scheme))
utilruntime.Must(v1alpha2.AddToScheme(scheme))
// +kubebuilder:scaffold:scheme

ctrl.SetLogger(zap.New(zap.UseDevMode(true)))
Copy link
Contributor Author

@onematchfox onematchfox Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was introduced in 2cb72c3 - although I can't see any reason why it's needed.

}

type Config struct {
Expand Down Expand Up @@ -182,22 +180,16 @@ func Start(getExtensionConfig GetExtensionConfig) {
flag.StringVar(&agent_translator.DefaultImageConfig.PullSecret, "image-pull-secret", "", "The pull secret name for the agent image.")
flag.StringVar(&agent_translator.DefaultImageConfig.Repository, "image-repository", agent_translator.DefaultImageConfig.Repository, "The repository to use for the agent image.")

opts := zap.Options{
Development: true,
}
opts := zap.Options{}
opts.BindFlags(flag.CommandLine)
flag.Parse()

logger := zap.New(zap.UseFlagOptions(&opts))

logger.Info("Starting KAgent Controller", "version", Version, "git_commit", GitCommit, "build_date", BuildDate)
logger.Info("Config", "config", cfg)

ctrl.SetLogger(logger)

goruntime.SetMaxProcs(logger)
setupLog.Info("Starting KAgent Controller", "version", Version, "git_commit", GitCommit, "build_date", BuildDate, "config", cfg)

setupLog.Info("Starting KAgent Controller", "version", Version, "git_commit", GitCommit, "build_date", BuildDate)
goruntime.SetMaxProcs(logger)

// if the enable-http2 flag is false (the default), http/2 should be disabled
// due to its vulnerabilities. More specifically, disabling http/2 will
Expand Down
2 changes: 0 additions & 2 deletions helm/kagent/templates/controller-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,6 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.namespace
- name: LOG_LEVEL
value: {{ .Values.controller.loglevel | quote }}
- name: OTEL_TRACING_ENABLED
value: {{ .Values.otel.tracing.enabled | quote }}
- name: OTEL_EXPORTER_OTLP_ENDPOINT
Expand Down
Loading