fix(helm): remove sqlite volume+mount if database is postgres #1140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onematchfox
requested review from
EItanya,
ilackarms and
yuval-k
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a cleanup issue from #1133 by conditionally rendering the SQLite volume and volume mount only when the database type is set to sqlite. When using postgres, these resources are no longer created, reducing unnecessary resource definitions in the Kubernetes deployment.
Key Changes
- Added conditional logic to render
volumesandvolumeMountsblocks only when needed (when database type is sqlite OR when custom volumes/volumeMounts are provided) - Added a new test case to verify sqlite volume/mount exclusion when using postgres with extra volumes
- Fixed comment formatting/indentation in values.yaml for consistency
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
helm/kagent/values.yaml |
Updated comment indentation for volumes and volumeMounts example documentation |
helm/kagent/templates/controller-deployment.yaml |
Added conditionals to only render volumes and volumeMounts blocks when database type is sqlite or when custom volumes are provided |
helm/kagent/tests/controller-deployment_test.yaml |
Added test case to verify sqlite volume/mount are not rendered when using postgres with extra volumes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
onematchfox
force-pushed
the
postgres-no-sqlite-volume
branch
2 times, most recently
from
2e7f055 to
359326c
Compare
Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
onematchfox
force-pushed
the
postgres-no-sqlite-volume
branch
from
359326c to
2ddb346
Compare
EItanya
approved these changes
Dec 2, 2025
GTRekter
pushed a commit
to GTRekter/kagent
that referenced
this pull request
Dec 4, 2025
…-dev#1140) Another artifact of kagent-dev#1133. No need for the sqlite volume+mount when database is set to postgres. Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> Signed-off-by: Ivan Porta <porta.ivan@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another artifact of #1133. No need for the sqlite volume+mount when database is set to postgres.