Skip to content

Conversation

@onematchfox
Copy link
Contributor

Closes #1125

Copilot AI review requested due to automatic review settings December 8, 2025 07:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the ability to configure the A2A (Agent-to-Agent) base URL via Helm chart values, addressing issue #1125. This allows users to specify how the controller service should be addressed by clients connecting to the A2A Server endpoint.

Key Changes:

  • Added a2aBaseUrl configuration parameter to the controller section in values.yaml
  • Configured the A2A_BASE_URL environment variable in the controller ConfigMap
  • Added comprehensive tests to verify both default and custom URL configurations

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
helm/kagent/values.yaml Adds a2aBaseUrl configuration parameter with default value and documentation
helm/kagent/templates/controller-configmap.yaml Exposes the A2A base URL as an environment variable to the controller
helm/kagent/tests/controller-deployment_test.yaml Adds tests for default and custom A2A base URL values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@onematchfox
Copy link
Contributor Author

Linting is failing on a change that was part of #1154.

@EItanya
Copy link
Contributor

EItanya commented Dec 8, 2025

Linting is failing on a change that was part of #1154.

Super weird, do you mind fixing it quick and then we can merge this

Later edit: #1165 shouid fix this 🤞

Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
@onematchfox
Copy link
Contributor Author

Later edit: #1165 shouid fix this 🤞

Thanks. Rebased so hopefully everything passes now.

@EItanya EItanya merged commit f935871 into kagent-dev:main Dec 9, 2025
17 checks passed
@onematchfox onematchfox deleted the a2a-base-url branch January 21, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Support configurable server url for a2a

2 participants