feat: allow configuring uvicorn log level via env var#1281
feat: allow configuring uvicorn log level via env var#1281EItanya merged 2 commits intokagent-dev:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds configurability for the Uvicorn server log level in the ADK CLI via UVICORN_LOG_LEVEL, with fallback to LOG_LEVEL and default info, addressing #1269.
Changes:
- Read
UVICORN_LOG_LEVEL(fallback toLOG_LEVEL, defaultinfo) and normalize it. - Pass the resolved log level into both
uvicorn.run()call sites (staticandruncommands).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| kagent_url_override = os.getenv("KAGENT_URL") | ||
| sts_well_known_uri = os.getenv("STS_WELL_KNOWN_URI") | ||
| propagate_token = os.getenv("KAGENT_PROPAGATE_TOKEN") | ||
| uvicorn_log_level = os.getenv("UVICORN_LOG_LEVEL", os.getenv("LOG_LEVEL", "info")).lower() |
There was a problem hiding this comment.
uvicorn_log_level is derived from LOG_LEVEL/UVICORN_LOG_LEVEL without sanitizing/normalizing beyond .lower(). If LOG_LEVEL is set to a numeric value (which Python logging accepts) or either env var is set but empty/whitespace, this will pass an invalid log_level through to uvicorn.run(). Consider .strip() plus handling numeric levels (e.g., map 20→"info") and falling back to "info" when the value is empty/invalid.
| uvicorn_log_level = os.getenv("UVICORN_LOG_LEVEL", os.getenv("LOG_LEVEL", "info")).lower() | |
| _raw_uvicorn_log_level = os.getenv("UVICORN_LOG_LEVEL") | |
| if _raw_uvicorn_log_level is None: | |
| _raw_uvicorn_log_level = os.getenv("LOG_LEVEL") | |
| if _raw_uvicorn_log_level is None: | |
| _raw_uvicorn_log_level = "info" | |
| _raw_uvicorn_log_level = _raw_uvicorn_log_level.strip() | |
| allowed_uvicorn_levels = {"critical", "error", "warning", "info", "debug", "trace"} | |
| if not _raw_uvicorn_log_level: | |
| uvicorn_log_level = "info" | |
| elif _raw_uvicorn_log_level.isdigit(): | |
| # Map numeric logging levels (e.g., 20) to their textual names (e.g., "info") | |
| numeric_level = int(_raw_uvicorn_log_level) | |
| level_name = logging.getLevelName(numeric_level) | |
| if isinstance(level_name, str): | |
| level_name = level_name.lower() | |
| uvicorn_log_level = level_name if level_name in allowed_uvicorn_levels else "info" | |
| else: | |
| uvicorn_log_level = "info" | |
| else: | |
| level_name = _raw_uvicorn_log_level.lower() | |
| uvicorn_log_level = level_name if level_name in allowed_uvicorn_levels else "info" |
Read the UVICORN_LOG_LEVEL environment variable (falling back to LOG_LEVEL, then 'info') and pass it to uvicorn.run() in both the 'static' and 'run' commands. This allows users to control uvicorn's log verbosity at deployment time without code changes. Fixes kagent-dev#1269 Signed-off-by: OpSpawn <opspawn@users.noreply.github.com>
opspawn
force-pushed
the
fix/1269-uvicorn-log-level
branch
from
e2861db to
a96ccca
Compare
|
Hi @EItanya — gentle nudge on this one. It's been approved for 3+ days and all real checks are passing (the e2e failure is a known flaky test that also fails on main). Would you be able to merge when you get a chance? Thanks! |
|
Hi @EItanya — Thanks for the approval! Is there anything else needed to get this merged? The only CI failure is test-e2e, which appears to be a known flaky test (recent main branch CI runs also show e2e failures). All other 14 checks pass. Happy to adjust if needed. |
Signed-off-by: opspawn <opspawn@users.noreply.github.com>
|
Hi @EItanya — this PR was approved on Feb 12 and all CI checks pass. Is there anything blocking the merge, or can it be merged? Happy to make any additional changes if needed. Thanks! |
2 participants
Adds support for configuring the uvicorn server log level via UVICORN_LOG_LEVEL env var. Falls back to LOG_LEVEL, then info. Fixes #1269