-
Notifications
You must be signed in to change notification settings - Fork 353
Support for Anthropic/AzureAI models #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EItanya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main comment on this PR has to do with the use of map[string]interface{}. Totally makes sense why these would look like a good option coming from a JS/Python world. But typically in go you should create a type to represent it when using it within the code. map[string]interface{] is typically used to represent JSON you don't know the format of, but we know the format of all of the JSON in this case.
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
72ea2d0 to
56aef29
Compare
|
Hello, |
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
EItanya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better, but still have the same major comment about the API
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
I think I address all feedback with the latest commit. |
This PR updates the ModelConfig CRD and adds support for Anthropic and Azure OpenAI (still needs to be tested). I've also updated the Agent CRD to reference the ModelConfig + other changes that were necessary to dynamically create the model in autogen based on the ModelConfig resource.
There are also bunch of changes in the UI to support the backend changes.
Here's how to test this out:
Similar for Azure:
closes: #174