Skip to content

Conversation

@nimishamehta5
Copy link
Contributor

@nimishamehta5 nimishamehta5 commented Jun 3, 2025

  • Renames the cilium-crd agent meant mainly for policy management, to cilliim-policy-agent.

  • Add a general-purpose cilium-manager agent for managing Cilium resources.

  • Add a cilium-debug agent as a dedicated troubleshooting agent for Cilium.

Testing:

Deployed to local kind cluster:

~ helm upgrade kagent ./helm/kagent/ --namespace kagent
Release "kagent" has been upgraded. Happy Helming!
NAME: kagent
LAST DEPLOYED: Sun Jun  8 15:22:07 2025
NAMESPACE: kagent
STATUS: deployed
REVISION: 4
TEST SUITE: None
NOTES:
################################ To open kagent UI: ###########################################
#
#  This is a Helm chart for Kagent, a Kubernetes agent.
#
#  1. Forward application port by running these commands in the terminal:
#  kubectl -n kagent port-forward service/kagent 8001:80
#
#  2. Then visit http://127.0.0.1:8001 to use the application.
#
###############################################################################################

~ k get agent | grep cilium
cilium-debug-agent               True       default-model-config
cilium-manager-agent             True       default-model-config
cilium-policy-agent              True       default-model-config

Invoking the agent with ollama provider:
Screenshot 2025-06-09 at 9 09 02 AM

Signed-off-by: Nimisha Mehta <nimishamehta5@gmail.com>
Copy link
Contributor

@EItanya EItanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution. A cilium manager seems like a great idea. I don't currently see any tools available to this agent though unless I'm missing something.

@nimishamehta5
Copy link
Contributor Author

@EItanya I think the tools were added by #385?

@EItanya
Copy link
Contributor

EItanya commented Jun 4, 2025

@EItanya I think the tools were added by #385?

Correct, but they're not given to this agent from what I can tell.

Signed-off-by: Nimisha Mehta <nimishamehta5@gmail.com>
@nimishamehta5 nimishamehta5 force-pushed the cilium-manager-agent branch from f0fb649 to d0c0cb7 Compare June 4, 2025 16:41
@nimishamehta5
Copy link
Contributor Author

@EItanya - I see now, I initially thought all tools were available automatically. Updated now to include the tools in the agent config, PTAL!

@nimishamehta5 nimishamehta5 requested a review from EItanya June 5, 2025 15:16
Copy link
Contributor

@EItanya EItanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tools. We have a hard limit in the system of 20 tools, that's because the models begin to behave much worse after that number. We will need to do one of 2 things:

  1. Break this up into multiple agents which chain together.
  2. Reduce the number of tools to what is strictly necessary

Signed-off-by: Nimisha Mehta <nimishamehta5@gmail.com>
@nimishamehta5 nimishamehta5 force-pushed the cilium-manager-agent branch from caad984 to dfade05 Compare June 6, 2025 04:08
@nimishamehta5
Copy link
Contributor Author

@EItanya, by "chain together" do you just mean refer to the other agent for certain things in the agent's instructions?
I've split the agent into two (cilium-manager for managing Cilium resources and cilium-debug as a dedicated troubleshooting agent). Lmk what you think.

Copy link
Contributor

@EItanya EItanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there. I really appreciate your PR here, but unfortunately it's pretty clear that it's generated nearly entirely by AI. I use A TON of AI in my development workflow, but I think it's important to ensure that the code you ask community members to review is ready to review.

I think let's circle back after you've tested these agents with a cilium installation.

@nimishamehta5
Copy link
Contributor Author

nimishamehta5 commented Jun 6, 2025

@EItanya, that's completely fair - I didn't mean to waste your time and I know you probably have a lot to review. In this case, since it's more agent instructions than code, I felt comfortable using AI to generate the instructions. Let me mark this PR as a draft again, and test the agent at my end before asking for another review. Sorry again for any wasted time!

Edit: Just realized I can't mark it draft now, but will let you know when it's ready for another review.

Signed-off-by: Nimisha Mehta <nimishamehta5@gmail.com>
@nimishamehta5 nimishamehta5 force-pushed the cilium-manager-agent branch from d0a94ba to 5641ee1 Compare June 8, 2025 22:28
nimishamehta5 and others added 2 commits June 8, 2025 15:43
Signed-off-by: Nimisha Mehta <nimishamehta5@gmail.com>
@nimishamehta5 nimishamehta5 requested a review from EItanya June 9, 2025 16:10
@EItanya EItanya merged commit dbac85f into kagent-dev:main Jun 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants