-
Notifications
You must be signed in to change notification settings - Fork 392
Add Cilium manager agent #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nimisha Mehta <nimishamehta5@gmail.com>
EItanya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the contribution. A cilium manager seems like a great idea. I don't currently see any tools available to this agent though unless I'm missing something.
Signed-off-by: Nimisha Mehta <nimishamehta5@gmail.com>
f0fb649 to
d0c0cb7
Compare
|
@EItanya - I see now, I initially thought all tools were available automatically. Updated now to include the tools in the agent config, PTAL! |
EItanya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tools. We have a hard limit in the system of 20 tools, that's because the models begin to behave much worse after that number. We will need to do one of 2 things:
- Break this up into multiple agents which chain together.
- Reduce the number of tools to what is strictly necessary
Signed-off-by: Nimisha Mehta <nimishamehta5@gmail.com>
caad984 to
dfade05
Compare
|
@EItanya, by "chain together" do you just mean refer to the other agent for certain things in the agent's instructions? |
EItanya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there. I really appreciate your PR here, but unfortunately it's pretty clear that it's generated nearly entirely by AI. I use A TON of AI in my development workflow, but I think it's important to ensure that the code you ask community members to review is ready to review.
I think let's circle back after you've tested these agents with a cilium installation.
|
@EItanya, that's completely fair - I didn't mean to waste your time and I know you probably have a lot to review. In this case, since it's more agent instructions than code, I felt comfortable using AI to generate the instructions. Let me mark this PR as a draft again, and test the agent at my end before asking for another review. Sorry again for any wasted time! Edit: Just realized I can't mark it draft now, but will let you know when it's ready for another review. |
Signed-off-by: Nimisha Mehta <nimishamehta5@gmail.com>
d0a94ba to
5641ee1
Compare
Signed-off-by: Nimisha Mehta <nimishamehta5@gmail.com>
Renames the
cilium-crdagent meant mainly for policy management, tocilliim-policy-agent.Add a general-purpose
cilium-manageragent for managing Cilium resources.Add a
cilium-debugagent as a dedicated troubleshooting agent for Cilium.Testing:
Deployed to local kind cluster:
Invoking the agent with ollama provider:
