Skip to content

Conversation

@onematchfox
Copy link
Contributor

@onematchfox onematchfox commented Jul 30, 2025

Contains a fix that I'm particularly interested 😉. Not exactly sure what the process is for doing this. Is this all there is to it, or am I missing something?

Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
@onematchfox onematchfox marked this pull request as ready for review July 30, 2025 16:12
Copilot AI review requested due to automatic review settings July 30, 2025 16:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the autogen dependency from commit c5b893d to 1ca7419 (version 0.7.1) to incorporate a specific fix that the author is interested in. The change updates all three autogen packages consistently across the project.

Key changes:

  • Updates git commit hash for autogen-core, autogen-agentchat, and autogen-ext dependencies
  • Adds corresponding entries in the uv.sources section for dependency resolution

Comment on lines 92 to +96
[tool.uv.sources]
kagent = { workspace = true }
autogen-agentchat = { git = "https://github.com/Microsoft/autogen", subdirectory = "python/packages/autogen-agentchat", rev = "1ca7419213027c548eb340b2eb08f3032993e78b" }
autogen-core = { git = "https://github.com/Microsoft/autogen", subdirectory = "python/packages/autogen-core", rev = "1ca7419213027c548eb340b2eb08f3032993e78b" }
autogen-ext = { git = "https://github.com/Microsoft/autogen", subdirectory = "python/packages/autogen-ext", rev = "1ca7419213027c548eb340b2eb08f3032993e78b" }
Copy link

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git commit hash is duplicated across multiple entries. Consider defining it as a variable or constant to reduce duplication and make future updates easier.

Suggested change
[tool.uv.sources]
kagent = { workspace = true }
autogen-agentchat = { git = "https://github.com/Microsoft/autogen", subdirectory = "python/packages/autogen-agentchat", rev = "1ca7419213027c548eb340b2eb08f3032993e78b" }
autogen-core = { git = "https://github.com/Microsoft/autogen", subdirectory = "python/packages/autogen-core", rev = "1ca7419213027c548eb340b2eb08f3032993e78b" }
autogen-ext = { git = "https://github.com/Microsoft/autogen", subdirectory = "python/packages/autogen-ext", rev = "1ca7419213027c548eb340b2eb08f3032993e78b" }
[tool.constants]
commit_hash = "1ca7419213027c548eb340b2eb08f3032993e78b"
[tool.uv.sources]
kagent = { workspace = true }
autogen-agentchat = { git = "https://github.com/Microsoft/autogen", subdirectory = "python/packages/autogen-agentchat", rev = tool.constants.commit_hash }
autogen-core = { git = "https://github.com/Microsoft/autogen", subdirectory = "python/packages/autogen-core", rev = tool.constants.commit_hash }
autogen-ext = { git = "https://github.com/Microsoft/autogen", subdirectory = "python/packages/autogen-ext", rev = tool.constants.commit_hash }

Copilot uses AI. Check for mistakes.
@onematchfox
Copy link
Contributor Author

Would normally wait for CI checks to complete successfully before marking as ready, but I need a maintainer to kick those off :)

@EItanya
Copy link
Contributor

EItanya commented Jul 31, 2025

Hey there, as of the merging of #671 the declarative backend of kagent is now ADK as we've been discussing in the community meetings the last few weeks. Happy to chat through impact of that on the use-case you're looking for

@onematchfox
Copy link
Contributor Author

Hey there, as of the merging of #671 the declarative backend of kagent is now ADK as we've been discussing in the community meetings the last few weeks. Happy to chat through impact of that on the use-case you're looking for

Thanks for letting me know. Let me get to grips with what that change, and if I still have issues, then I'll get back to you :)

@onematchfox onematchfox deleted the autogen-0.7.1 branch August 26, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants