feat: make sse timeout configurable #800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes the SSE (Server-Sent Events) timeout configurable for the streaming connection in the kagent application. The change allows users to specify a custom timeout value instead of using a hardcoded value.
- Adds a new
timeoutconfiguration parameter to the streaming settings - Updates the Helm chart to expose the timeout configuration
- Refactors the A2A reconciler to use a structured options pattern for better extensibility
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| helm/kagent/values.yaml | Adds timeout configuration with 60s default value |
| helm/kagent/templates/controller-deployment.yaml | Passes the timeout configuration as command-line argument |
| go/pkg/app/app.go | Adds timeout field to Config struct and command-line flag handling |
| go/internal/controller/a2a/a2a_reconciler.go | Refactors to use ClientOptions struct and applies timeout configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
peterj
previously approved these changes
Aug 25, 2025
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
…to eitanya/sse-timeout
yuval-k
approved these changes
Aug 25, 2025
inFocus7
pushed a commit
to inFocus7/kagent
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
yanivmn
pushed a commit
to yanivmn/kagent
that referenced
this pull request
Aug 28, 2025
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.